Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prerelease] Multicurrency variable config update #22

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

fivetran-avinash
Copy link
Contributor

PR Overview

This PR will address the following Issue/Feature: Internal ticket

This PR will result in the following new package version: v0.3.2-a2

This changes variable configuration logic but the field column values remain the same.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

This pre-release introduces the following updates.

Bug Fixes

  • Modified the variable logic in zuora__using_multicurrency in these models so that the *_amount values are called by default rather than *_amount_home_currency when the variable isn't configured:
    • int_zuora__transaction_grouped
    • zuora__line_item_history
    • zuora__monthly_recurring_revenue
  • Single currency is now the proper default and multicurrency customers must leverage the variable to enable that functionality. (#21)

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • [NA] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • [NA] The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Ensured compiled code (on Redshift based on customer's ticket) returned *_amount values are called rather than *_amount_home_currency in the variable config.

Screenshot 2025-02-13 at 2 51 10 PM Screenshot 2025-02-13 at 2 50 55 PM Screenshot 2025-02-13 at 2 50 41 PM Screenshot 2025-02-13 at 2 48 45 PM

If you had to summarize this PR in an emoji, which would it be?

💃

@fivetran-avinash fivetran-avinash self-assigned this Feb 13, 2025
@fivetran-avinash fivetran-avinash changed the title Prerelease/multicurrency variable config update [Prerelease] Multicurrency variable config update Feb 13, 2025
Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for pre-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants