-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prerelease] Multicurrency variable config update #22
Open
fivetran-avinash
wants to merge
12
commits into
main
Choose a base branch
from
prerelease/multicurrency-variable-config-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Prerelease] Multicurrency variable config update #22
fivetran-avinash
wants to merge
12
commits into
main
from
prerelease/multicurrency-variable-config-update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for pre-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: Internal ticket
This PR will result in the following new package version: v0.3.2-a2
This changes variable configuration logic but the field column values remain the same.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
This pre-release introduces the following updates.
Bug Fixes
zuora__using_multicurrency
in these models so that the*_amount
values are called by default rather than*_amount_home_currency
when the variable isn't configured:int_zuora__transaction_grouped
zuora__line_item_history
zuora__monthly_recurring_revenue
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Ensured compiled code (on Redshift based on customer's ticket) returned
*_amount
values are called rather than*_amount_home_currency
in the variable config.If you had to summarize this PR in an emoji, which would it be?
💃