-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature that added ad squad & campaign in the ad report #33
Changes from 9 commits
6010466
0f90d3e
6a6f3f7
eebb110
f57ee2d
6b35f4b
3a64440
cf38880
641a5f4
4c03630
7513f3f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
name: 'snapchat_ads' | ||
version: '0.6.2' | ||
version: '0.8.0' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yikes, looks like we missed updating this in the last release. |
||
config-version: 2 | ||
require-dbt-version: [">=1.3.0", "<2.0.0"] | ||
vars: | ||
|
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,9 +1,9 @@ | ||||||
name: 'snapchat_ads_integration_tests' | ||||||
version: '0.7.0' | ||||||
version: '0.8.0' | ||||||
profile: 'integration_tests' | ||||||
config-version: 2 | ||||||
|
||||||
vars: | ||||||
vars: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Whitespace removal
Suggested change
|
||||||
snapchat_ads_source: | ||||||
snapchat_ads_schema: snapchat_ads_integration_tests_6 | ||||||
snapchat_ads_ad_account_history_identifier: "snapchat_ad_account_history_data" | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While you're making a new test, can you also update the consistency tests to ensure the conversions is included moving forward. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
{{ config( | ||
tags="fivetran_validations", | ||
enabled=var('fivetran_validation_tests_enabled', false) | ||
) }} | ||
|
||
with ad_day_source as ( | ||
|
||
select | ||
ad_id, | ||
cast(date_hour as date) as date_day_source | ||
from {{ ref('stg_snapchat_ads__ad_hourly_report') }} | ||
{{ dbt_utils.group_by(2) }} | ||
), | ||
|
||
ad_day_end as ( | ||
|
||
select | ||
ad_id, | ||
date_day as date_day_end | ||
from {{ ref('snapchat_ads__ad_report') }} | ||
|
||
{{ dbt_utils.group_by(2) }} | ||
), | ||
|
||
final as ( | ||
-- test will fail if any rows from source not found in end | ||
(select * from ad_day_source | ||
except distinct | ||
select * from ad_day_end) | ||
|
||
union all -- union since we only care if rows are produced | ||
|
||
-- test will fail if any rows from end are not found in source | ||
(select * from ad_day_end | ||
except distinct | ||
select * from ad_day_source) | ||
) | ||
|
||
select * | ||
from final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you consolidate this into the one bullet above. "Fields added include:" doesn't need to be a separate bullet. But I would like the separate fields to be their own sub bullets still.