Feature that added ad squad & campaign in the ad report #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…campaign-and-ad-squad-to-ad-report
…ad-to-ad-report Feature: Add ad_squad and campaign to ad report
4 tasks
…hub.com/fivetran/dbt_snapchat_ads into feature/add-ad-squad-campaign-ad-report
fivetran-joemarkiewicz
approved these changes
Feb 18, 2025
CHANGELOG.md
Outdated
Comment on lines
6
to
10
| - Fields added include: | ||
| - `ad_squad_id` | ||
| - `ad_squad_name` | ||
| - `campaign_id` | ||
| - `campaign_name` |
There was a problem hiding this comment.
Can you consolidate this into the one bullet above. "Fields added include:" doesn't need to be a separate bullet. But I would like the separate fields to be their own sub bullets still.
| @@ -1,5 +1,5 @@ | |||
| name: 'snapchat_ads' | |||
| version: '0.6.2' | |||
| version: '0.8.0' | |||
There was a problem hiding this comment.
Yikes, looks like we missed updating this in the last release.
integration_tests/dbt_project.yml
Outdated
| profile: 'integration_tests' | ||
| config-version: 2 | ||
|
|
||
| vars: | ||
| vars: |
There was a problem hiding this comment.
Whitespace removal
Suggested change
| vars: | |
| vars: |
There was a problem hiding this comment.
While you're making a new test, can you also update the consistency tests to ensure the conversions is included moving forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: [#31] contribution via @JeremyDOwens
This PR will result in the following new package version: 0.8.0
Added new fields, leading to a schema change.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
This release introduces the following updates:
Breaking Changes
snapchat_ads__ad_reportmodel, so that they can eventually be incorporated in thedbt_ad_reportingpackage for thead_reporting__ad_reportmodel. (#33)ad_squad_idad_squad_namecampaign_idcampaign_nameUnder The Hood
ad_squad_idandcampaign_idinsnapchat.ymlforsnapchat_ads__ad_reportandsnapchat_ads__url_reportto more closely align with other ad reporting packages. (#33)snapchat_ads__ad_reportmaintains the same row grain count forad_idanddate_daybetweens the source and end models. (#33)Documentation
snapchat.ymlwith new above field additions. (#33)Contributors
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Validated that these fields were brought through to the end model, as well as ensured new tests passed
If you had to summarize this PR in an emoji, which would it be?
🦑