Feature/public disabled models #154
Merged
+48
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
LGTM with one comment to add a change to the README.
I'm not approving yet because we will not plan to merge this to main. Instead we will create the pre-release and have the pre-release point to this branch. We can then test if the Quickstart functionality works as expected once deployed.
fivetran-joemarkiewicz
approved these changes
Feb 4, 2025
Co-authored-by: Joe Markiewicz <[email protected]>
CHANGELOG.md
Outdated
|
|
||
| ## Documentation | ||
| - Added Quickstart model counts to README. ([#152](https://github.com/fivetran/dbt_hubspot/pull/152)) | ||
| - Corrected references to connectors and connections in the README. ([#152](https://github.com/fivetran/dbt_hubspot/pull/152)) | ||
|
|
||
| ## Under the hood | ||
| - Added `hubspot__daily_ticket_history` and `hubspot__tickets` models to the `public_models` list in `quickstart.yml`. |
There was a problem hiding this comment.
Would similarly add the PR link to the end of this sentence.
fivetran-avinash
approved these changes
Feb 5, 2025
Co-authored-by: Avinash Kunnath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
Issue: Support engagement_communication model #143
This PR tests models that are disabled by default for compatibility with quickstart.
hubspot__daily_ticket_historyandhubspot__ticketstopublic_modelsConfirming
hubspot_service_enabled: trueduring regen: