Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nov 2024 schema #32
Nov 2024 schema #32
Changes from 20 commits
2f1fdc1
046da4c
632def4
7084f63
c3a9b78
5559078
1ddd8c0
9b0b948
6746c2b
dd7458d
2bf9dfe
c7df6f7
f941c5f
f61eafe
5c26fa4
77fd1f0
5555efc
105389c
aeb2564
e3e45db
9fc03a1
90753f0
43d4f81
cfafe69
4dc1890
a2bbfeb
fd64d93
43fb57b
75bfc3d
661da32
729bef4
c387358
4e4d751
25ffcac
5d48c99
1a1c0ea
76dd744
b153019
964b8a3
5f3333e
1e7c869
afc2caa
4589fb7
32e773e
2a0ba4a
1e57b4b
f27cd33
42cfa02
cb9818f
9dda153
8076c46
deb51f8
f2854cc
36b64c9
30d4c8a
98d739c
43d2de2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add in here the bugfix of materializing the reporting grains as tables. This will result in extra tables, but it's important to highlight why this change was made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should call out the models these fields have been removed from--based on the yml updates, it looks like it's just the subscription report?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's correct, updated!
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
This file was deleted.
This file was deleted.
This file was deleted.