Apple store nov 2024 updates #27
Open
+147
−242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
@fivetran-reneeli this generally looks good with just a few small reminder and suggestion comments. This will be ready once the upstream PRs are approved
| # dbt_app_reporting v0.5.0 | ||
|
|
||
| ## Breaking Changes | ||
| - This package has been upgraded following schema changes upstream in the `dbt_apple_store` package. For more information, refer to the `dbt_apple_store` [release notes](https://github.com/fivetran/dbt_apple_store/releases/tag/v0.5.0). |
There was a problem hiding this comment.
Can you highlight here if any changes other than the upstream dependency switch are expected for the customer here?
Comment on lines
+4
to
+10
| - git: https://github.com/fivetran/dbt_apple_store.git | ||
| revision: nov_2024_schema | ||
| warn-unpinned: false | ||
|
|
||
| # - package: fivetran/apple_store | ||
| # version: [">=0.5.0", "<0.6.0"] | ||
|
|
There was a problem hiding this comment.
Reminder to switch before merge and release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: #28
This PR will result in the following new package version: v0.5.0
Schema changes from Nov 2024
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
to be completed
Breaking Changes
dbt_apple_storepackage. For more information, refer to thedbt_apple_storerelease notes.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
If you had to summarize this PR in an emoji, which would it be?
💃