-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Union schema compatibility #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks great! This will be ready to ship once the upstream PRs are all set and the packages.yml is updates.
Also before merging we should add the auto releaser to this package.
packages.yml
Outdated
# version: [">=0.4.0", "<0.5.0"] | ||
# - package: fivetran/apple_store | ||
# version: [">=0.4.0", "<0.5.0"] | ||
- git: https://github.com/fivetran/dbt_apple_store.git | ||
revision: MagicBot/add-union-schema | ||
warn-unpinned: false | ||
- git: https://github.com/fivetran/dbt_google_play.git | ||
revision: MagicBot/add-union-schema | ||
warn-unpinned: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to swap before release
Issue:
[Feature] Support for running with multiple Apple/Google Store connectors #20
Regen dbt docs after approval
Confirm the following files were correctly updated automatically:
joinswindow functions (partition by)Manual updates:
source_relation
to downstream models if necessarysource_relation
in unique-combination-of-cols if necessaryValidation:
When not using unioning, tests in the folder
tests/consistency/row_counts
passSpot check with seed data for unioning:
Also: