Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Union schema compatibility #21

Merged
merged 15 commits into from
Jul 24, 2024

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Jul 17, 2024

Issue:

Confirm the following files were correctly updated automatically:

  • CHANGELOG
  • README
  • app_reporting.yml
  • docs.md
  • joins
  • window functions (partition by)
  • 'source_relation' column added
  • tests

Manual updates:

  • Add source_relation to downstream models if necessary
  • Finish any incomplete/incorrect joins/partitions
  • Update tests to include source_relation in unique-combination-of-cols if necessary
    • May need to remove some uniqueness tests in favor of the combo test

Validation:

  • When not using unioning, tests in the folder tests/consistency/row_counts pass

    • It is is expected that the consistency tests will not pass when unioning
  • Spot check with seed data for unioning:

    • Screenshot 2024-07-18 at 2 58 54 PM
  • Also:

    • see internal ticket

Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks great! This will be ready to ship once the upstream PRs are all set and the packages.yml is updates.

Also before merging we should add the auto releaser to this package.

packages.yml Outdated
Comment on lines 2 to 11
# version: [">=0.4.0", "<0.5.0"]
# - package: fivetran/apple_store
# version: [">=0.4.0", "<0.5.0"]
- git: https://github.com/fivetran/dbt_apple_store.git
revision: MagicBot/add-union-schema
warn-unpinned: false
- git: https://github.com/fivetran/dbt_google_play.git
revision: MagicBot/add-union-schema
warn-unpinned: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to swap before release

@fivetran-catfritz fivetran-catfritz merged commit aae8b47 into main Jul 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support for running with multiple Apple/Google Store connectors
2 participants