Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more descriptive panic messages in uffd examples #4999

Merged

Conversation

ShadowCurse
Copy link
Contributor

Changes

Add additional info to the panic messages in uffd examples.

Reason

Will help to debug potential issue.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@ShadowCurse ShadowCurse self-assigned this Jan 17, 2025
@ShadowCurse ShadowCurse added Type: Enhancement Indicates new feature requests Status: Awaiting review Indicates that a pull request is ready to be reviewed labels Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (525e686) to head (7d2ce57).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4999   +/-   ##
=======================================
  Coverage   83.10%   83.10%           
=======================================
  Files         245      245           
  Lines       26723    26723           
=======================================
  Hits        22209    22209           
  Misses       4514     4514           
Flag Coverage Δ
5.10-c5n.metal 83.56% <ø> (-0.01%) ⬇️
5.10-m5n.metal 83.54% <ø> (ø)
5.10-m6a.metal 82.76% <ø> (ø)
5.10-m6g.metal 79.57% <ø> (ø)
5.10-m6i.metal 83.54% <ø> (-0.01%) ⬇️
5.10-m7g.metal 79.57% <ø> (ø)
6.1-c5n.metal 83.56% <ø> (-0.01%) ⬇️
6.1-m5n.metal 83.55% <ø> (+<0.01%) ⬆️
6.1-m6a.metal 82.77% <ø> (+<0.01%) ⬆️
6.1-m6g.metal 79.57% <ø> (ø)
6.1-m6i.metal 83.54% <ø> (-0.01%) ⬇️
6.1-m7g.metal 79.56% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShadowCurse ShadowCurse force-pushed the uffd_better_panic_messages branch from 93052df to 6403685 Compare January 17, 2025 14:59
Add additional info to the panic messages in uffd examples
to aid with potential errors.

Signed-off-by: Egor Lazarchuk <[email protected]>
@ShadowCurse ShadowCurse force-pushed the uffd_better_panic_messages branch from 6403685 to 7d2ce57 Compare January 17, 2025 15:14
@roypat roypat merged commit da1cc8a into firecracker-microvm:main Jan 20, 2025
6 of 7 checks passed
@ShadowCurse ShadowCurse deleted the uffd_better_panic_messages branch January 20, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants