Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AMD support larger extended function entries #4995

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JackThomson2
Copy link
Contributor

@JackThomson2 JackThomson2 commented Jan 14, 2025

Changes

Updated the logic for setting the largest extended function entry, to take the largest between host CPU value and 0x8000_0021. The minimum has also been bumped to 0x8000_0021 to allow setting values regarding SRSO.

Reason

Currently we cap the largest entry to 0x8000001d which prevents extra entries being passed, of interest is 0x8000_0021 which is used to inform the guest that the appropriate SRSO microcode updates have been applied

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.95%. Comparing base (94826a8) to head (38300e6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4995   +/-   ##
=======================================
  Coverage   83.95%   83.95%           
=======================================
  Files         248      248           
  Lines       27839    27845    +6     
=======================================
+ Hits        23371    23377    +6     
  Misses       4468     4468           
Flag Coverage Δ
5.10-c5n.metal 84.53% <ø> (ø)
5.10-m5n.metal 84.51% <ø> (-0.01%) ⬇️
5.10-m6a.metal 83.80% <100.00%> (-0.01%) ⬇️
5.10-m6g.metal 80.63% <ø> (ø)
5.10-m6i.metal 84.50% <ø> (-0.01%) ⬇️
5.10-m7g.metal 80.63% <ø> (ø)
6.1-c5n.metal 84.52% <ø> (ø)
6.1-m5n.metal 84.51% <ø> (-0.01%) ⬇️
6.1-m6a.metal 83.80% <100.00%> (-0.01%) ⬇️
6.1-m6g.metal 80.63% <ø> (-0.01%) ⬇️
6.1-m6i.metal 84.50% <ø> (+<0.01%) ⬆️
6.1-m7g.metal 80.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackThomson2 JackThomson2 force-pushed the feat/amd_extended_fn_range_support branch from 80ebedb to 2469548 Compare January 14, 2025 15:59
Updated the logic for setting the largest extended function entry, to
take the largest between host CPU value and 0x8000_0021. The minimum has
also been bumped to 0x8000_0021 to allow setting values regarding SRSO.

Signed-off-by: Jack Thomson <[email protected]>
@JackThomson2 JackThomson2 force-pushed the feat/amd_extended_fn_range_support branch from 2469548 to 38300e6 Compare January 14, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant