feat: add the data bundle sample #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyokone
force-pushed
the
chore/databundle
branch
from
d5996d0 to
81b8099
Compare
Lyokone
changed the title
thatfiredev
reviewed
Aug 14, 2024
There was a problem hiding this comment.
Thanks for opening this PR, @Lyokone !
Just 2 minor comments
Comment on lines
112
to
113
| String string = response.body; | ||
| final buffer = Uint8List.fromList(string.codeUnits); |
There was a problem hiding this comment.
nit: can we name this variable body instead? I think it's more descriptive than string.
Suggested change
| String string = response.body; | |
| final buffer = Uint8List.fromList(string.codeUnits); | |
| String body = response.body; | |
| final buffer = Uint8List.fromList(body.codeUnits); |
|
|
||
| // Use the cached named query | ||
| final results = await FirebaseFirestore.instance.namedQueryGet( | ||
| "example-query", |
There was a problem hiding this comment.
The Web, iOS and Android samples use latest-stories-query (see example) - let's use that for consistency across languages.
Suggested change
| "example-query", | |
| "latest-stories-query", |
5 tasks
|
I'll update https://firebase.google.com/docs/firestore/bundles accordingly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding:
Data Bundle sample for Firestore
Issues fixed by this PR (if any):
Risk Level
Pre-submit checklist