Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI Android targets #105

Merged
merged 8 commits into from
Jul 22, 2022
Merged

Add CI Android targets #105

merged 8 commits into from
Jul 22, 2022

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Jul 20, 2022

Adds a CI Workflow to build the testapps against the publicly available packaged SDK.

  • Borrows heavily from the Firebase C++ SDK build scripts.
  • Nightly builds at 1am PST.
  • Builds triggered on PRs.
  • Some updates to the android build dependencies in order for the build to succeed with the cmake version installed on the GitHub CI runners.
  • Add build verification using GitHub Actions #23

@@ -0,0 +1,119 @@
# Copyright 2020 Google LLC
Copy link
Contributor Author

@DellaBitta DellaBitta Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this file to this Android-only build PR because build_testapps.py refers to it and I thought it would be better to submit it now and alter it later than to prune build_testapps.py of all xcode references only to add them back in later.

It seems safer this way.

@@ -0,0 +1,186 @@
# Copyright 2022 Google LLC
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is mainly a directly copy of the one from the C++ SDK repo. Mainly changes have been made to the paths.

@@ -0,0 +1,94 @@
#!/usr/bin/env python
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly a direct copy of the C++ SDK version, with the removal of all of the vcpkg functions.

@@ -0,0 +1,139 @@
# Copyright 2022 Google LLC
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly a direct copy of the Firebase C++ SDK version, but the comments which contain the example have been updated with the test app bundle ids / naming convention.

@DellaBitta DellaBitta marked this pull request as ready for review July 20, 2022 19:31
Copy link

@sunmou99 sunmou99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Because the build scripts are almost identical to the scripts in C++ repo, it maybe better to create a github action which handles environment setting steps and the build steps in the future.

@DellaBitta
Copy link
Contributor Author

Yes, I was thinking along the same lines!

@DellaBitta DellaBitta merged commit 84c6f1e into main Jul 22, 2022
@DellaBitta DellaBitta deleted the feature/android_ci branch July 22, 2022 12:37
@firebase firebase locked and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants