Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go): Added simulated document-based context support #2415

Merged
merged 14 commits into from
Mar 24, 2025

Conversation

sahdev77
Copy link
Contributor

@sahdev77 sahdev77 commented Mar 21, 2025

Addition of augmentWithContext middleware to simulated document-based grounding support.
Resolving : #1926

Checklist (if applicable):

Copy link
Collaborator

@apascal07 apascal07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the other middleware, please either write or adjust an existing sample (there are samples that pass docs into the request already) to verify that it does what we want.

@apascal07 apascal07 changed the title feat(go):Handling of context provided in the messages or documents feat(go): Added simulated document-based context support Mar 21, 2025
@apascal07
Copy link
Collaborator

I think some of the generator_test.go tests are failing because they pass in docs but previous those docs did nothing. Please update.

@sahdev77 sahdev77 marked this pull request as ready for review March 22, 2025 15:37
@sahdev77 sahdev77 requested a review from apascal07 March 22, 2025 15:38
@github-actions github-actions bot added the python Python label Mar 24, 2025
@apascal07 apascal07 enabled auto-merge (squash) March 24, 2025 19:47
@apascal07 apascal07 merged commit d3bd4c7 into main Mar 24, 2025
10 checks passed
@apascal07 apascal07 deleted the sahdev/augment-with-context branch March 24, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants