Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go): Fixed error propagation in Reflection API. #2410

Merged
merged 7 commits into from
Mar 25, 2025
Merged

fix(go): Fixed error propagation in Reflection API. #2410

merged 7 commits into from
Mar 25, 2025

Conversation

apascal07
Copy link
Collaborator

@apascal07 apascal07 commented Mar 20, 2025 •
edited
Loading

The "View Trace" button still doesn't show up despite traceId being properly set, can't figure out why, but I'll iterate on this later. This is already an improvement.

Checklist (if applicable):

@github-actions github-actions bot added the python Python label Mar 21, 2025
@apascal07 apascal07 requested a review from pavelgj March 21, 2025 19:15
@apascal07 apascal07 marked this pull request as ready for review March 21, 2025 19:15
@apascal07 apascal07 enabled auto-merge (squash) March 21, 2025 19:27
@github-actions github-actions bot added docs Improvements or additions to documentation config labels Mar 25, 2025
@apascal07 apascal07 merged commit 5ca3b14 into main Mar 25, 2025
13 checks passed
@apascal07 apascal07 deleted the ap/go-error-handling branch March 25, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugoaguirre hugoaguirre hugoaguirre approved these changes

@pavelgj pavelgj Awaiting requested review from pavelgj pavelgj is a code owner

@huangjeff5 huangjeff5 Awaiting requested review from huangjeff5

Assignees
No one assigned
Labels
config docs Improvements or additions to documentation go js python Python tooling
Projects
Genkit Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apascal07 @hugoaguirre