Skip to content

Minor fixes from bugbash #8365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Mar 26, 2025
Merged

Minor fixes from bugbash #8365

merged 28 commits into from
Mar 26, 2025

Conversation

inlined
Copy link
Member

@inlined inlined commented Mar 25, 2025

  1. Writes a sentinel apphosting.emulator.yaml file if no env vars are overwritten
  2. Tweaks command to be consistent with other commands in this feature set.

Probably doesn't merit a changelog

inlined and others added 26 commits March 24, 2025 09:26
@inlined
Can grant access to emails (user, group, SA)
f484c23
@inlined
Support multiple secrets
cc0e362
@inlined
Lint and changelog
57f26df
@inlined
Checkpoint
7ca61fd
@inlined
Merge branch 'master' into inlined.grantaccess-user
b34eea2
@inlined
Merge branch 'inlined.grantaccess-user' into inlined.secrets-set
e334b25
@inlined
Firebase secrets set can be a test-key only
35e324d
@inlined
Lint fix
f788229
@inlined
Changelog
7ab4e6f
@inlined
Fix case where project root wasn't detected with apphosting.local.yaml
f8c4778
@inlined
Merge branch 'master' into inlined.secrets-set
6749ec4
@inlined
Checkpoint
abfd3de
@inlined
fixes
93ae21c
@inlined
Merge branch 'inlined.secrets-set' into inlined.emulators-init
caa5af9
@inlined
config.ts helpers done
f12c29e
@inlined
Merge branch 'master' into inlined.secrets-set
15020c4
@inlined
Ready for review!
589c5ef
@inlined
Changelog
e36c241
@inlined
Restore more detailed error message
a356c1a
@inlined
PR feedback
0ccdd69
@inlined
Merge branch 'inlined.secrets-set' into inlined.emulators-init
420a0cc
@inlined
Fix merge issues
7d6bfea
@inlined
Manual testing fixes
b0179ef
@inlined
Merge branch 'master' into inlined.emulators-init
d162a52
@inlined
Fix merge break
665d764
@inlined
PR bugfixes
e96fb23
@inlined inlined requested review from taeold and annajowang March 25, 2025 20:38
Base automatically changed from inlined.emulators-init to master March 25, 2025 23:05
@inlined inlined enabled auto-merge (squash) March 25, 2025 23:08
@inlined inlined merged commit 8c6e645 into master Mar 26, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annajowang annajowang annajowang approved these changes

@taeold taeold Awaiting requested review from taeold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inlined @annajowang @joehan