fix: Change photoUrl to photoURL in cloud functions auth provider payload #4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see based on the type definitions in firebase-admin-node that uid should perhaps also be returned here? If someone can sanity check this, it would also be a trivial change to add here. |
|
any updates on this? The inconsistency is causing issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Firebase SDKs expect the Photo URL property on a user payload to be named
photoURLbut it is returned from the emulator asphotoUrl. The property name is changed correctly for the top-level user info, but not for the array of third-party provider info. See #2887 for more context.Scenarios Tested
I haven't manually tested this as it is a clear typo from copying over the types from the REST API. All tests are still passing.