Fix get and delete endpoints for storage not accepting the documented endpoint: /storage/v1/b/bucket/o/object #4132
+19
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While I was testing getting and deleting pictures from the firestore emulator I noticed that I was getting errors about the object not being found.
I'm noticed that my client (golang client) was making requests to:
I wanted to see what was happening in the emulator and noticed that there is no listener for those endpoints. Suspecting it could be an issue with the golang client I checked the cloud storage documentation for the official paths:
https://cloud.google.com/storage/docs/json_api/v1/objects/get
https://cloud.google.com/storage/docs/json_api/v1/objects/delete
They seem to match what the golang client is doing.
I made the change on this pull request and things started working.
Scenarios Tested
This is a snippet of the code that was failing and works after my changes: