-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create buildable branch for Swift 6 and Xcode 16+ #14601
base: swift-6
Are you sure you want to change the base?
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
Disables a bunch of GHA tests and marks much of the existing code as
@unchecked Sendable
. These will eventually need to be fixed but for now we can kick them down the road and still have Swift 6 compliance. There's some improvements in this PR too: addition of a saferos_unfair_lock
inFIRAllocatedUnfairLock
, which we can drop once we get to iOS 16+, and some fixes to things that could not have possibly worked before but somehow did.To find
@unchecked Sendable
types that need to be made checked Sendable or refactored, search for/* TODO: sendable */
.To find disabled tests that need to be re-enabled, search for
# TODO(Swift 6):
.