Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift 6] Sessions Swift 6 changes #14575

Merged
merged 5 commits into from
Mar 17, 2025
Merged

[Swift 6] Sessions Swift 6 changes #14575

merged 5 commits into from
Mar 17, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Mar 13, 2025

This is the common Swift 6 error where we need an atomic wrapper to protect the mutable state. We can reuse this wrapper across multiple SDKs so I'll work in subsequent PRs to do so.

#no-changelog

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like the naming too!

@ncooke3 ncooke3 added sessions Changes pertaining to the Firebase Sessions SDK swift-concurrency and removed do-not-merge labels Mar 17, 2025
@ncooke3 ncooke3 merged commit 487c97a into main Mar 17, 2025
41 of 42 checks passed
@ncooke3 ncooke3 deleted the nc/sessions-6 branch March 17, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sessions Changes pertaining to the Firebase Sessions SDK swift-concurrency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants