Firestore: Remove obsolete NOLINT comments #14347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4, build/c++tr1, build/namespaces_literals
dconeybe
force-pushed
the
dconeybe/CppLintRemoveObsoleteNoLintComments
branch
from
96fd28a to
605d689
Compare
cherylEnkidu
requested changes
Jan 17, 2025
| @@ -283,7 +280,6 @@ | |||
| 'build/include_order', | |||
| 'build/include_what_you_use', | |||
| 'build/namespaces_headers', | |||
| 'build/namespaces_literals', | |||
There was a problem hiding this comment.
Could you tell me why choose to remove 'build/namespaces_literals amd build/c++14 and build/c++tr1?
There was a problem hiding this comment.
I removed build/namespaces_literals, build/c++14, and build/c++tr1 because there are no more lint checks in cpplint.py that produce warnings in those categories and all mentions of those categories in "NOLINT" comments have been removed from the source code. So leaving them around is kind of like leaving "dead code", IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
NOLINTcomments from the code base that are obsolete as of #14320, which deleted obsolete c++11 and c++14 lint checks.#no-changelog