Update to gRPC 1.66.0 #14342
Update to gRPC 1.66.0 #14342
Conversation
There was a problem hiding this comment.
@cherylEnkidu @ncooke3 The binary distribution will also need to be updated before the next release.
| @@ -1,5 +1,6 @@ | |||
| # Unreleased | |||
| - [fixed] Fixed use-after-free bug when internally formatting strings. (#14306) | |||
| - [changed] Update gRPC dependency to 1.66. | |||
There was a problem hiding this comment.
Should this be marked as fixing #14323?
There was a problem hiding this comment.
I was on the fence about this. I personally haven't been able to verify that this fixes #14323 given that the issue is not deterministically reproducible. Based on the stack trace and @HannahShiSFB's comment, it's very likely.
There was a problem hiding this comment.
My perception is that the only reasonable next step for #14323 is asking a customer to validate if 1.66.0 addresses it, so we should do so and then reinvestigate if it doesn't fix it.
| @@ -105,8 +105,8 @@ Google Cloud Firestore is a NoSQL document database built for automatic scaling, | |||
| s.dependency 'abseil/time', abseil_version | |||
| s.dependency 'abseil/types', abseil_version | |||
|
|
|||
| s.dependency 'gRPC-Core', '~> 1.65.0' | |||
| s.dependency 'gRPC-C++', '~> 1.65.0' | |||
| s.dependency 'gRPC-Core', '~> 1.66.0' | |||
There was a problem hiding this comment.
If we're updating, why not get fully up to date with the latest 1.69
Upgrade the gRPC version to pick up the fix mentioned in #14323 (comment)