Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertex AI] Make ImagenImageRepresentable internal #14341

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

andrewheard
Copy link
Contributor

Updated the ImagenImageRepresentable and _ImagenImage visibility from public to internal since they are not needed until the SDK supports operations that accept images as input (e.g., upscaling or editing). This will reduce the API surface that needs to be reviewed in the API proposal for image generation.

Note: Renamed _ImagenImage to _InternalImagenImage and ImagenImageRepresentable._imagenImage to ImagenImageRepresentable._internalImagenImage. Although these are no longer public symbols, this is my proposed naming for when we do expose them publicly.

#14221
#no-changelog

@andrewheard andrewheard marked this pull request as ready for review January 13, 2025 22:41
@andrewheard andrewheard requested a review from paulb777 January 13, 2025 22:41
@andrewheard andrewheard merged commit dbbfb38 into vertex-imagen Jan 13, 2025
38 checks passed
@andrewheard andrewheard deleted the ah/vertex-imagen-rep-internal branch January 13, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants