Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logger): no longer replaces object duplicates with "CIRCULAR" #229

Merged
merged 3 commits into from
Mar 31, 2025
Merged

fix(logger): no longer replaces object duplicates with "CIRCULAR" #229

merged 3 commits into from
Mar 31, 2025

Conversation

CorieW
Copy link
Contributor

@CorieW CorieW commented Mar 11, 2025

Resolves #228

@CorieW CorieW force-pushed the @invertase/fix-logger-circular-removal branch 4 times, most recently from 27d850e to d934708 Compare March 11, 2025 17:14
@CorieW CorieW force-pushed the @invertase/fix-logger-circular-removal branch from d934708 to 786cb64 Compare March 11, 2025 17:15
@CorieW CorieW requested a review from cabljac March 11, 2025 22:59
@CorieW
Copy link
Contributor Author

CorieW commented Mar 11, 2025

Failing due to deprecation fixed by #230

cabljac
cabljac approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

taeold
taeold approved these changes Mar 31, 2025
View reviewed changes
@cabljac cabljac merged commit f933859 into main Mar 31, 2025
7 of 9 checks passed
@cabljac cabljac deleted the @invertase/fix-logger-circular-removal branch March 31, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taeold taeold taeold approved these changes

@cabljac cabljac cabljac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@CorieW @taeold @cabljac