Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default params #1707

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Add default params #1707

wants to merge 13 commits into from

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 2, 2025
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025 •
edited
Loading

✅  Integration test succeeded!

Requested by @jonsimantov on commit ebda697
Last updated: Thu Apr 3 16:12 PDT 2025
View integration test log & download artifacts

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 2, 2025
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 2, 2025
@github-actions github-actions bot removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Apr 2, 2025
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 2, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 2, 2025
@jonsimantov
Update so that null is handled for removing keys.
112684d 
Add ClearDefaultEventParameters since we can't pass in null.
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 3, 2025
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels Apr 3, 2025
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 3, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonsimantov