Skip to content

fallback mode #6856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fallback mode #6856

wants to merge 1 commit into from

Conversation

themiswang
Copy link
Contributor

@themiswang themiswang commented Apr 9, 2025 •
edited
Loading

Implement a fallback module fallback to pre multi-process support state.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 9, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (9eb1210) to 71.26% (bf0d347) by ?.

    47 individual files with coverage change

    FilenameBase (9eb1210)Merge (bf0d347)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    DaggerFirebaseSessionsComponent.java?94.23%?
    EventGDTLogger.kt?70.00%?
    EventGDTLogger_Factory.java?0.00%?
    FirebaseSessions.kt?53.85%?
    FirebaseSessionsComponent.kt?47.37%?
    FirebaseSessionsComponent_MainModule_Companion_ApplicationInfoFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionConfigsDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_TimeProviderFactory.java?100.00%?
    FirebaseSessionsComponent_MainModule_Companion_UuidGeneratorFactory.java?100.00%?
    FirebaseSessionsDependencies.kt?85.71%?
    FirebaseSessionsRegistrar.kt?90.91%?
    FirebaseSessions_Factory.java?0.00%?
    InstallationId.kt?100.00%?
    LocalOverrideSettings.kt?100.00%?
    LocalOverrideSettings_Factory.java?0.00%?
    ProcessDetailsProvider.kt?76.67%?
    RemoteSettings.kt?88.41%?
    RemoteSettingsFetcher.kt?10.00%?
    RemoteSettingsFetcher_Factory.java?0.00%?
    RemoteSettings_Factory.java?0.00%?
    SessionConfigs.kt?95.45%?
    SessionData.kt?0.00%?
    SessionDataSerializer_Factory.java?0.00%?
    SessionDetails.kt?85.71%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?98.00%?
    SessionFirelogPublisher.kt?78.57%?
    SessionFirelogPublisherImpl_Factory.java?0.00%?
    SessionGenerator.kt?100.00%?
    SessionGenerator_Factory.java?0.00%?
    SessionsActivityLifecycleCallbacks.kt?0.00%?
    SessionsActivityLifecycleCallbacks_Factory.java?0.00%?
    SessionsFallbackActivityLifecycleCallbacks.kt?0.00%?
    SessionsFallbackActivityLifecycleCallbacks_Factory.java?0.00%?
    SessionsSettings.kt?93.75%?
    SessionsSettings_Factory.java?0.00%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?80.56%?
    SettingsCacheImpl_Factory.java?0.00%?
    SettingsProvider.kt?50.00%?
    SharedSessionRepository.kt?0.00%?
    SharedSessionRepositoryImpl_Factory.java?0.00%?
    TimeProvider.kt?50.00%?
    UuidGenerator.kt?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qrOr9usVC4.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025 •
edited
Loading

Test Results

 32 files   32 suites   46s ⏱️
 68 tests  68 ✅ 0 💤 0 ❌
136 runs  136 ✅ 0 💤 0 ❌

Results for commit 0507bc2.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 9, 2025 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (9eb1210)Merge (bf0d347)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • firebase-sessions

    TypeBase (9eb1210)Merge (bf0d347)Diff
    aar?204 kB? (?)
    apk (aggressive)?532 kB? (?)
    apk (release)?5.78 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DCcaG92Y5n.html

@themiswang themiswang force-pushed the fallbackMode branch 2 times, most recently from c0cd393 to a6db12e Compare April 10, 2025 22:15
@themiswang themiswang marked this pull request as ready for review April 10, 2025 22:20
@themiswang themiswang requested review from mrober and tejasd April 10, 2025 22:20
@themiswang themiswang closed this Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrober mrober Awaiting requested review from mrober

@tejasd tejasd Awaiting requested review from tejasd

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@themiswang @google-oss-bot