[Functions] Several functions improvements #6796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By relying on the `MediaType` class, we can get more normalized results.
The old code use to throw, which stop any further processing. The change introduced later didn't, causing errors.
- Better code organization to make it easier to know which headers are being set - Process events from the buffer in case there's no empty line at the end
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Coverage Report 1Affected ProductsTest Logs |
Test Results14 files - 562 14 suites - 562 12s ⏱️ - 18m 54s Results for commit eb44bce. ± Comparison against base commit f9d1802. This pull request removes 3841 tests.♻️ This comment has been updated with latest results. |
Size Report 1Affected Products
Test Logs |
daymxn
approved these changes
Mar 24, 2025
firebase-functions/src/main/java/com/google/firebase/functions/PublisherStream.kt
Outdated
Show resolved
Hide resolved
tejasd
pushed a commit
that referenced
this pull request
Apr 1, 2025
These improvements are both in the SDK itself, and in the code used for the actual functions running in the cloud during integration testing: A summary of the changes is: - [Backend functions] Update the dependencies and node runtime version - [Backend functions] Add logging in case the client does not support streaming - [SDK] Use a more robust handle of the media type - [SDK] Fix issue introduced in #6773 that missed a return in case of error - [SDK] Other minor code fixes b/404814020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These improvements are both in the SDK itself, and in the code used for the actual functions running in the cloud during integration testing:
A summary of the changes is:
b/404814020