Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing :googleid component to package declaration #6791

Closed
wants to merge 3 commits into from
Closed

Add missing :googleid component to package declaration #6791

wants to merge 3 commits into from

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Mar 21, 2025

This prevents the library from being included in the generated recipe file

b/405222121

@rlazo rlazo requested a review from davidmotson March 21, 2025 00:34
@rlazo rlazo enabled auto-merge (squash) March 21, 2025 00:34
@rlazo rlazo requested a review from emilypgoogle March 21, 2025 00:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 21, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions GitHub Actions
Copy link
Contributor

Test Results

 1 032 files  ±0   1 032 suites  ±0   34m 14s ⏱️ -20s
 5 861 tests ±0   5 839 ✅ ±0  22 💤 ±0  0 ❌ ±0 
11 785 runs  ±0  11 741 ✅ ±0  44 💤 ±0  0 ❌ ±0 

Results for commit 5888cac. ± Comparison against base commit d0dc250.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (d0dc250) and merge commit (e13ab74).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/OgaOHN0twz.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (d0dc250) to 75.72% (e13ab74) by ?.

    68 individual files with coverage change

    FilenameBase (d0dc250)Merge (e13ab74)Diff
    AabUpdater.java?98.36%?
    AabUpdater_Factory.java?0.00%?
    ApkInstaller.java?100.00%?
    ApkInstaller_Factory.java?0.00%?
    ApkUpdater.java?92.63%?
    ApkUpdater_Factory.java?0.00%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppDistroComponent.java?0.00%?
    AppDistroComponent_MainModule_BindContentResolverFactory.java?0.00%?
    AppIconSource.java?84.62%?
    AppIconSource_Factory.java?100.00%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?71.58%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    DaggerAppDistroComponent.java?80.56%?
    DevModeDetector.java?9.09%?
    DevModeDetector_Factory.java?100.00%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?3.39%?
    FeedbackActivity_MembersInjector.java?0.00%?
    FeedbackSender.java?84.48%?
    FeedbackSender_Factory.java?0.00%?
    FeedbackTrigger.java?61.54%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?89.89%?
    FirebaseAppDistributionImpl_Factory.java?0.00%?
    FirebaseAppDistributionLifecycleNotifier.java?91.49%?
    FirebaseAppDistributionLifecycleNotifier_Factory.java?0.00%?
    FirebaseAppDistributionNotificationsManager.java?88.89%?
    FirebaseAppDistributionNotificationsManager_Factory.java?0.00%?
    FirebaseAppDistributionRegistrar.java?95.83%?
    FirebaseAppDistributionTesterApiClient.java?88.78%?
    FirebaseAppDistributionTesterApiClient_Factory.java?0.00%?
    HttpsUrlConnectionFactory.java?50.00%?
    HttpsUrlConnectionFactory_Factory.java?100.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.67%?
    LogWrapper.java?86.67%?
    NewReleaseFetcher.java?86.67%?
    NewReleaseFetcher_Factory.java?0.00%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?91.78%?
    ReleaseIdentifier_Factory.java?0.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?36.17%?
    ScreenshotTaker_Factory.java?0.00%?
    SequentialReference.java?100.00%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?100.00%?
    SignInStorage_Factory.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity_MembersInjector.java?0.00%?
    TaskCache.java?100.00%?
    TaskCompletionSourceCache.java?72.41%?
    TaskUtils.java?77.50%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?90.09%?
    TesterApiHttpClient_Factory.java?0.00%?
    TesterSignInManager.java?89.41%?
    TesterSignInManager_Factory.java?0.00%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskCache.java?91.30%?
    UpdateTaskImpl.java?76.32%?

  • firebase-database

    Overall coverage changed from 50.21% (d0dc250) to 50.16% (e13ab74) by -0.04%.

    FilenameBase (d0dc250)Merge (e13ab74)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%

  • firebase-firestore

    Overall coverage changed from 45.77% (d0dc250) to 45.77% (e13ab74) by +0.00%.

    FilenameBase (d0dc250)Merge (e13ab74)Diff
    DeleteMutation.java90.48%95.24%+4.76%

  • firebase-ml-modeldownloader

    Overall coverage changed from ? (d0dc250) to 82.11% (e13ab74) by ?.

    36 individual files with coverage change

    FilenameBase (d0dc250)Merge (e13ab74)Diff
    AutoFirebaseMlLogEventEncoder.java?100.00%?
    AutoValue_FirebaseMlLogEvent.java?56.60%?
    AutoValue_FirebaseMlLogEvent_DeleteModelLogEvent.java?58.33%?
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent.java?56.96%?
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent_ModelOptions.java?60.00%?
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent_ModelOptions_ModelInfo.java?56.25%?
    AutoValue_FirebaseMlLogEvent_SystemInfo.java?54.93%?
    CustomModel.java?72.13%?
    CustomModelDownloadConditions.java?88.46%?
    CustomModelDownloadService.java?79.89%?
    CustomModelDownloadService_Factory.java?0.00%?
    CustomModel_Factory.java?0.00%?
    CustomModel_Factory_Impl.java?0.00%?
    DaggerModelDownloaderComponent.java?100.00%?
    DataTransportMlEventSender.java?100.00%?
    DataTransportMlEventSender_Factory.java?0.00%?
    DownloadType.java?100.00%?
    FirebaseMlException.java?100.00%?
    FirebaseMlLogEvent.java?97.92%?
    FirebaseMlLogger.java?88.89%?
    FirebaseMlLogger_Factory.java?0.00%?
    FirebaseModelDownloader.java?84.66%?
    FirebaseModelDownloaderRegistrar.java?100.00%?
    FirebaseModelDownloader_Factory.java?0.00%?
    ModelDownloader.kt?91.67%?
    ModelDownloaderComponent.java?25.00%?
    ModelDownloaderComponent_MainModule_AppPackageNameFactory.java?0.00%?
    ModelDownloaderComponent_MainModule_AppVersionCodeFactory.java?0.00%?
    ModelDownloaderComponent_MainModule_FirebaseOptionsFactory.java?0.00%?
    ModelDownloaderComponent_MainModule_PersistenceKeyFactory.java?0.00%?
    ModelFileDownloadService.java?88.46%?
    ModelFileDownloadService_Factory.java?0.00%?
    ModelFileManager.java?82.28%?
    ModelFileManager_Factory.java?0.00%?
    SharedPreferencesUtil.java?97.26%?
    SharedPreferencesUtil_Factory.java?0.00%?

  • firebase-storage

    Overall coverage changed from 83.96% (d0dc250) to 84.33% (e13ab74) by +0.37%.

    FilenameBase (d0dc250)Merge (e13ab74)Diff
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java83.38%83.99%+0.60%
    UploadTask.java81.52%83.17%+1.65%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xXV8KaA61v.html

@thatfiredev
Copy link
Member

Duplicate of #6789 😬

See also #6790 that fixes the failing plugins-check

@rlazo rlazo closed this Mar 21, 2025
auto-merge was automatically disabled March 21, 2025 13:25

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmotson davidmotson Awaiting requested review from davidmotson

@emilypgoogle emilypgoogle Awaiting requested review from emilypgoogle

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @thatfiredev