Extend Firebase SDK with new APIs to consume streaming callable function response #6602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion response. - Handling the server-sent event (SSE) parsing internally - Providing proper error handling and connection management - Maintaining memory efficiency for long-running streams
…ion response. - Handling the server-sent event (SSE) parsing internally - Providing proper error handling and connection management - Maintaining memory efficiency for long-running streams
MustafaJadid2025
force-pushed
the
stream-functions-api
branch
from
a6fbadc to
f0bd47a
Compare
…m-functions-api # Conflicts: # firebase-functions/src/androidTest/java/com/google/firebase/functions/StramTests.kt
MustafaJadid2025
force-pushed
the
stream-functions-api
branch
from
f0bd47a to
6d3012d
Compare
…ivestreams.Subscriber interface.
…ndroid-sdk-fork into stream-functions-api
|
is this PR ready for review? please assign @emilypgoogle and myself as reviewers as soon as it's ready. Thanks |
emilypgoogle
requested changes
Feb 12, 2025
firebase-functions/src/main/java/com/google/firebase/functions/FirebaseFunctions.kt
Outdated
Show resolved
Hide resolved
firebase-functions/src/main/java/com/google/firebase/functions/FirebaseFunctions.kt
Outdated
Show resolved
Hide resolved
firebase-functions/src/main/java/com/google/firebase/functions/FirebaseFunctions.kt
Outdated
Show resolved
Hide resolved
firebase-functions/src/main/java/com/google/firebase/functions/FirebaseFunctions.kt
Outdated
Show resolved
Hide resolved
firebase-functions/src/main/java/com/google/firebase/functions/StreamResponse.kt
Outdated
Show resolved
Hide resolved
firebase-functions/src/androidTest/java/com/google/firebase/functions/StreamTests.kt
Show resolved
Hide resolved
firebase-functions/src/main/java/com/google/firebase/functions/HttpsCallableReference.kt
Outdated
Show resolved
Hide resolved
|
Please, regenerate the api.txt file |
rlazo
reviewed
Feb 28, 2025
firebase-functions/src/main/java/com/google/firebase/functions/FirebaseFunctions.kt
Outdated
Show resolved
Hide resolved
firebase-functions/src/main/java/com/google/firebase/functions/HttpsCallableReference.kt
Outdated
Show resolved
Hide resolved
firebase-functions/src/main/java/com/google/firebase/functions/PublisherStream.kt
Show resolved
Hide resolved
emilypgoogle
requested changes
Feb 28, 2025
firebase-functions/src/androidTest/java/com/google/firebase/functions/StreamTests.kt
Show resolved
Hide resolved
firebase-functions/src/main/java/com/google/firebase/functions/PublisherStream.kt
Outdated
Show resolved
Hide resolved
firebase-functions/src/main/java/com/google/firebase/functions/PublisherStream.kt
Outdated
Show resolved
Hide resolved
Done |
…Synchronize request(n), and Handle Late Subscribers.
emilypgoogle
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Aside from my excessive synchronization comments which are non-blocking, all of my concerns were addressed and this seems to add the feature in line with reactive stream behavior expectations. @rlazo should make sure his concerns are also addressed
ncooke3
reviewed
Mar 5, 2025
firebase-functions/src/main/java/com/google/firebase/functions/HttpsCallableReference.kt
Outdated
Show resolved
Hide resolved
…LargeData on index.js. - Modify genStreamError.
thatfiredev
reviewed
Mar 10, 2025
firebase-functions/src/main/java/com/google/firebase/functions/HttpsCallableReference.kt
Show resolved
Hide resolved
rlazo
approved these changes
Mar 10, 2025
gubatron
pushed a commit
to gubatron/firebase-android-sdk
that referenced
this pull request
Mar 24, 2025
…ion response (firebase#6602) Extend Firebase SDK with new APIs to consume streaming callable function response. - Handling the server-sent event (SSE) parsing internally - Providing proper error handling and connection management - Maintaining memory efficiency for long-running streams --------- Co-authored-by: Rodrigo Lazo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend Firebase SDK with new APIs to consume streaming callable function response.