Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use crypto.randomUUID() instead of uuid module #2802

Closed
wants to merge 1 commit into from

Conversation

nikeee
Copy link

@nikeee nikeee commented Dec 5, 2024

The crypto global is available in all supported Node.js versions as well as in all major browsers. The uuid module is rendered unnecessary for uuidv4.

The `crypto` global is available in all supported Node.js versions as well as [in all major browsers](https://caniuse.com/mdn-api_crypto_randomuuid).
The uuid module is rendered unnecessary for uuidv4.
Copy link

google-cla bot commented Dec 5, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pquerner
Copy link

As far as I can see the package uuid priorities the native crypto module if its available. So I would leave this as is.

@nikeee nikeee closed this Jan 31, 2025
@nikeee nikeee deleted the remove-uuid-package branch January 31, 2025 11:28
@nikeee
Copy link
Author

nikeee commented Jan 31, 2025

The main motivation behind this PR was to reduce traffic in the realms of e18e. firebaes-admin has around 1466130 downloads per week. So requiring a 3.7 kB package results in 5.5GB/week, which is approx. 286 GB per year.
The crypto object isn't loaded by default in Node.js 18 (could be solved by using require("crypto").webcrypto), which is still supported until end of April. So according to the package.json's engine, this would be a breaking change. Maybe someone can do it some day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants