-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth: Allow expiry to be specified in .createCustomToken #1017
base: master
Are you sure you want to change the base?
Conversation
Thanks for your contribution, @rhodgkins. This requires an internal API review and the API should not be Node.js specific. In addition, we need to check the service we use internally to mint these tokens are ok with the proposed changes. We may even need an internal launch review for this. Will need to double check it. |
cb735b1
to
d75d4cd
Compare
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
72ea79b
to
d75d4cd
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
d75d4cd
to
2961634
Compare
🙃 |
aa76b2c
to
be0e2ee
Compare
216161c
to
4683e65
Compare
4683e65
to
e4f2d83
Compare
e4f2d83
to
f8688fd
Compare
Hi @rhodgkins, This is a great feature that we are also looking to implement. |
No idea sorry! I’ve given up waiting / keeping this up to date against conflicts now 🤷♂️ |
It's really impressive the speed at which things move around here. I'm not being sarcastic, I'm genuinely impressed. @rhodgkins thanks for the contribution. Hopefully in another year we'll have the needed reviews 🤞 |
18 months later - any updates? Happy to rebase this one last time if it's realistically going to be used... |
Hi @rhodgkins Thank you again for your contribution! Since this feature is not included in any of the immediate roadmaps, it is going to take time to complete the internal approvals. I can't unfortunately promise you a timeline for when this feature will be released. However, I will discuss this with the team so that we can do our best to move forward. @prameshj PTAL. It looks like bojeil-google@ already discussed this internally. Thank you! |
Resolves #1016
If this gets a 👍 happy to do any changes needed, etc.!