feat: add support for API 35 EdgeToEdge #2187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update versions update version fix more tests fixes sdk bump fix gradle save the response Sign In working chore: upgrade Gradle, AGP and Kotlin chore: move namespace to build.gradle chore: upgrade Lint API add new lines at EOF for checkstyle ci: temporarily stop building proguard-test test: update robolectric and use Looper ignore test clean update ci remove comments Bad code fix? unused imports more more fix fixes fix more fixes
Lyokone
force-pushed
the
feat/edge-to-edge
branch
from
150bc9d to
2e17c04
Compare
marinacoelho
approved these changes
Mar 7, 2025
thatfiredev
reviewed
Mar 11, 2025
|
|
||
| <!-- Override the base FirebaseUI theme for edge-to-edge support --> | ||
| <style name="FirebaseUI" parent="Theme.MaterialComponents.DayNight.DarkActionBar"> | ||
| <item name="android:windowOptOutEdgeToEdgeEnforcement">true</item> |
There was a problem hiding this comment.
We shouldn't rely on windowOptOutEdgeToEdgeEnforcement as that's going away in Android 16: https://developer.android.com/about/versions/16/behavior-changes-16#edge-to-edge
thatfiredev
changed the base branch from
version-9.0.0-dev
to
version-9.1.0-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:
./gradlew checkto ensure the Travis build passes.