-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Code Quality: Replaced stack-allocated GUIDs with RVA-inlined GUIDs #16993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is the removal of ThrowOnFailure intended?
- Can you use the generator on the Storage Provider IID property as well?
|
|
|
2 is probably okay, but personally I would use GuidRVAGen on the |
4851a8e
to
41ca094
Compare
Now this is alright? |
@yaira2 This is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM!
Co-authored-by: Steve <[email protected]> Signed-off-by: 0x5BFA <[email protected]>
Co-authored-by: Steve <[email protected]> Signed-off-by: 0x5BFA <[email protected]>
Co-authored-by: Steve <[email protected]> Signed-off-by: 0x5BFA <[email protected]>
Co-authored-by: Steve <[email protected]> Signed-off-by: 0x5BFA <[email protected]>
Resolved / Related Issues
This is a QOL PR for CsWin32.
Steps used to test these changes
CC: @dongle-the-gadget I used your SG to do this; I'd like to request your review.