Skip to content

Feature: Drag to clone #16920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 17, 2025
Merged

Feature: Drag to clone #16920

merged 12 commits into from
Mar 17, 2025

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Mar 11, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Confirmed that drag & dropping a GitHub url triggers the clone repo action
  2. Confirmed the repo is properly cloned and status is displayed in status center
  3. Confirmed the error dialog displays when there is an issue cloning the repo

@yaira2 yaira2 marked this pull request as draft March 11, 2025 15:43
@yaira2 yaira2 marked this pull request as ready for review March 16, 2025 15:33
@yaira2 yaira2 requested a review from ferrariofilippo March 16, 2025 15:41
@yaira2 yaira2 marked this pull request as draft March 16, 2025 15:53
@yaira2 yaira2 marked this pull request as ready for review March 16, 2025 19:56
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested yet because I'm havng troubles with the .slnx

@yaira2 yaira2 requested a review from ferrariofilippo March 17, 2025 14:17
@ferrariofilippo
Copy link
Contributor

Is there a way to fix this? (X MB processed of 0B)
image

@yaira2
Copy link
Member Author

yaira2 commented Mar 17, 2025

Is there a way to fix this? (X MB processed of 0B)

We can by using the GitHub api, but this will require users to authenticate themselves.

Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@yaira2 yaira2 merged commit 1a1b651 into main Mar 17, 2025
8 checks passed
@yaira2 yaira2 deleted the ya/DragToClone branch March 17, 2025 15:35
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Clone repo when dragging GitHub url from browser
2 participants