This repository was archived by the owner on Oct 31, 2023. It is now read-only.
feat: implement taper challenge handling, and upate proofs #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicola @porcuquine need the default values for tapering, to finish this |
nicola
reviewed
Mar 15, 2019
src/bin/game.rs
Outdated
| .long("taper") | ||
| .help("fraction of challenges by which to taper at each layer") | ||
| .default_value("0.0"), | ||
| ) |
There was a problem hiding this comment.
This should not be an option, tapered should be the default zigzag
nicola
reviewed
Mar 15, 2019
src/bin/game.rs
Outdated
| .default_value("0.0"), | ||
| ) | ||
| .arg( | ||
| Arg::with_name("taper-layers") |
There was a problem hiding this comment.
This should not be an option, tapered should be the default zigzag
nicola
reviewed
Mar 15, 2019
| layers: val.layers.map(|v| v as i32), | ||
| expansion_degree: val.zigzag.as_ref().map(|v| v.expansion_degree as i32), | ||
| layers: val.zigzag.as_ref().map(|v| v.layers as i32), | ||
| is_tapered: val.zigzag.as_ref().map(|v| v.is_tapered), |
There was a problem hiding this comment.
we should never run a non-tapered zigzag
|
@dignifiedquire Default taper is 0.3. |
|
see my comments ^ |
|
I will approve this only when this either becomes the only way to run zigzag or the default way (with updated readme) |
|
@nicola @porcuquine updated to have fixed values for tapering and challenges, please recheck those values |
|
@dignifiedquire I am sorry, it is supposed to be |
porcuquine
changed the title
nicola
approved these changes
Mar 19, 2019
nicola
approved these changes
Mar 19, 2019
dignifiedquire
force-pushed
the
fix-challenges
branch
from
672a3ca to
9937470
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #38