Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test([kh]amt): improve test coverage #2124

Merged
merged 3 commits into from
Apr 8, 2025
Merged

test([kh]amt): improve test coverage #2124

merged 3 commits into from
Apr 8, 2025

Conversation

Stebalien
Copy link
Member

No description provided.

@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Apr 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.12%. Comparing base (34dd64e) to head (02f10fe).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2124      +/-   ##
==========================================
+ Coverage   76.77%   77.12%   +0.35%     
==========================================
  Files         149      149              
  Lines       15631    15631              
==========================================
+ Hits        12000    12056      +56     
+ Misses       3631     3575      -56     

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Stebalien Stebalien force-pushed the steb/tests branch 6 times, most recently from 6312f1f to aa40fc0 Compare April 4, 2025 19:31
@Stebalien Stebalien changed the title test(kamt): improve test coverage test(kamt/amt): improve test coverage Apr 7, 2025
@Stebalien Stebalien changed the title test(kamt/amt): improve test coverage test([kh]amt): improve test coverage Apr 7, 2025
Base automatically changed from steb/update-rust to master April 7, 2025 22:51
@Stebalien Stebalien marked this pull request as ready for review April 8, 2025 01:24
@Stebalien Stebalien requested a review from rvagg April 8, 2025 01:24
let cids = CidChecker::new(vec![
"bafy2bzacedy4ypl2vedhdqep3llnwko6vrtfiys5flciz2f3c55pl4whlhlqm",
"bafy2bzacedy4ypl2vedhdqep3llnwko6vrtfiys5flciz2f3c55pl4whlhlqm",
"bafy2bzacecrxqeuuk34jsrol3azfpgy35ldw4bpgsa6pdxvzj262jzpvoekye",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new root at the end of the test (there are now three checks in the test). We have the CID checks there to avoid unintentional changes.

@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Apr 8, 2025
@Stebalien Stebalien merged commit 84458c8 into master Apr 8, 2025
15 checks passed
@Stebalien Stebalien deleted the steb/tests branch April 8, 2025 19:20
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

3 participants