Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Grafana tutorial and templates #675

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rjan90
Copy link
Collaborator

@rjan90 rjan90 commented Oct 24, 2023

Porting over the Grafana dashboard tutorial from here: filecoin-project/lotus#11276 and updated in: filecoin-project/lotus#12934.

Can be merged once 12934 lands

@BigLep
Copy link
Member

BigLep commented Sep 24, 2024

@rjan90 : would it be helpful for me to review so this can land?

@rjan90
Copy link
Collaborator Author

rjan90 commented Sep 26, 2024

I think the progress on this PR stopped, when I mentally expanded the scope of this work by trying to write up "how to setup Graphing on a remote machine", but for now I think setting it up locally is just fine. I will look at doing a cleanup of this PR on 2024-09-30

Adding Grafana dashboard tutorial
Update weights across tutorial section
@rjan90 rjan90 force-pushed the feat/add-grafana-tutorial branch from ffbb6fb to 856ccc3 Compare November 14, 2024 03:58
@BigLep BigLep marked this pull request as draft January 6, 2025 20:16
@BigLep BigLep moved this from 🐱 Todo to 👊 Needs Commitment in FilOz Mar 17, 2025
chore: update Grafana tutorial
@rjan90 rjan90 changed the title Add Grafana tutorial feat: add Grafana tutorial and templates Apr 10, 2025
@rjan90 rjan90 marked this pull request as ready for review April 10, 2025 16:05
@rjan90 rjan90 moved this from 👊 Needs Commitment to 🔎 Awaiting Review in FilOz Apr 10, 2025
Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust your judgement here, but I would look at how to reduce the duplication between this and filecoin-project/lotus#12934 . Ideally we're doing more pointing from one to the other than copy/pasting

brew install prometheus

# start prometheus
prometheus --config.file=lotus/metrics/prometheus.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does lotus/metrics/prometheus.yml live? In the Lotus repo right? How come we don't need to do this on the Linux side? Maybe use a variable to represent the lotus directory so it's clear that everyone needs to set it for themselves?


**Note:** These instructions have been tested on Ubuntu 23.04 and on Mac M1.

## Install and start Prometheus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thing about this is that it is complete for someone, but the downside is we have a snapshot in time for how to install. Pointing to install docs of the respective project are more likely to stay updated. Your call.


1. Log in to Grafana using the web interface.
2. Navigate to "Home" > "Dashboards" > Click the drop down menu in the "New" button and select "Import"
3. Paste any of the existing dashboards in lotus/metrics/grafana into the "Import via panel json" panel.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Paste any of the existing dashboards in lotus/metrics/grafana into the "Import via panel json" panel.
3. Paste any of the existing dashboards in `lotus/metrics/grafana` into the "Import via panel json" panel.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of duplication between this and what's in https://github.com/filecoin-project/lotus/blob/master/metrics/README.md . Do we just want to have one point to the other for those parts?

5. Select the Prometheus datasource you created earlier
6. Click "Import"

### Available Dashboards
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-project-automation github-project-automation bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✔️ Approved by reviewer
Development

Successfully merging this pull request may close these issues.

2 participants