-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an allocator with installation ID #215
Merged
kacperzuk-neti
merged 1 commit into
main
from
bugfix/new-allocators-are-created-without-installation_id
Jul 18, 2024
Merged
Create an allocator with installation ID #215
kacperzuk-neti
merged 1 commit into
main
from
bugfix/new-allocators-are-created-without-installation_id
Jul 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filip-L
force-pushed
the
bugfix/new-allocators-are-created-without-installation_id
branch
from
July 17, 2024 09:08
814312c
to
a2c1040
Compare
kacperzuk-neti
requested changes
Jul 17, 2024
kacperzuk-neti
requested changes
Jul 17, 2024
Filip-L
force-pushed
the
bugfix/new-allocators-are-created-without-installation_id
branch
from
July 18, 2024 07:39
556533a
to
fbaa28f
Compare
kacperzuk-neti
approved these changes
Jul 18, 2024
kacperzuk-neti
deleted the
bugfix/new-allocators-are-created-without-installation_id
branch
July 18, 2024 10:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an allocator with installation ID
Description:
The allocator was created without an installation ID, which caused numerous issues with the system's proper functioning. From now on, an installation ID is required when creating a new allocator.
The new process for creating an allocator involves the following steps:
Additionally, the logic for the endpoint
/allocator/create
has been moved to the appropriate file, and the code has been cleaned up by removing the unnecessary endpoint/allocator/update_installation_id
along with its associated functions.Deployment Considerations:
No special actions are required.