Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an allocator with installation ID #215

Merged

Conversation

Filip-L
Copy link
Collaborator

@Filip-L Filip-L commented Jul 17, 2024

Create an allocator with installation ID

Description:
The allocator was created without an installation ID, which caused numerous issues with the system's proper functioning. From now on, an installation ID is required when creating a new allocator.

The new process for creating an allocator involves the following steps:

  • Allocator must have a repository set up with default GitHub initialization
  • GitHub application must be installed

Additionally, the logic for the endpoint /allocator/create has been moved to the appropriate file, and the code has been cleaned up by removing the unnecessary endpoint /allocator/update_installation_id along with its associated functions.

Deployment Considerations:

No special actions are required.

@Filip-L Filip-L force-pushed the bugfix/new-allocators-are-created-without-installation_id branch from 814312c to a2c1040 Compare July 17, 2024 09:08
fplus-lib/src/core/mod.rs Outdated Show resolved Hide resolved
fplus-lib/src/core/allocator/mod.rs Outdated Show resolved Hide resolved
fplus-lib/src/core/allocator/mod.rs Outdated Show resolved Hide resolved
fplus-lib/src/core/allocator/mod.rs Outdated Show resolved Hide resolved
fplus-lib/src/core/allocator/mod.rs Outdated Show resolved Hide resolved
fplus-lib/src/core/allocator/mod.rs Outdated Show resolved Hide resolved
fplus-lib/src/external_services/github.rs Outdated Show resolved Hide resolved
fplus-lib/src/external_services/github.rs Outdated Show resolved Hide resolved
fplus-lib/src/external_services/github.rs Outdated Show resolved Hide resolved
fplus-lib/src/external_services/github.rs Outdated Show resolved Hide resolved
@Filip-L Filip-L force-pushed the bugfix/new-allocators-are-created-without-installation_id branch from 556533a to fbaa28f Compare July 18, 2024 07:39
@Filip-L Filip-L marked this pull request as ready for review July 18, 2024 07:58
@kacperzuk-neti kacperzuk-neti merged commit 608337e into main Jul 18, 2024
3 checks passed
@kacperzuk-neti kacperzuk-neti deleted the bugfix/new-allocators-are-created-without-installation_id branch July 18, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants