This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 174
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
removed the data-attr based approach. Now using ?full=largeimagesrcpa…
…th. No ".r" flag is needed anymore either, no gif is used. Thanks Andy Hume for the idea!
- Loading branch information
scottjehl
committed
May 24, 2011
1 parent
3a48ca5
commit fdd89a2
Showing
4 changed files
with
7 additions
and
53 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
fdd89a2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious why you decided to switch from the data-attr approach to a query string method for including the larger image file.
fdd89a2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fdd89a2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Scott. I had already looked at Picturefill, which seemed like another decent approach. Also, there's a new jQuery plugin that is similar called jQuery Picture if you haven't seen that yet:
http://jquerypicture.com
I asked about the data-attr approach because I felt it was more semantic and easier to read, plus it would be easy to extend for more image size options with multiple attributes. Jeremy Keith took this concept and talked about it a bit on his blog, comparing the loading of the mobile image and replacing it with the full image to our old friend the lowsrc attribute:
http://adactio.com/journal/5208/
At any rate, there's no perfect solution at this point, but I really appreciate all your hard work on this stuff so far. Keep it up.