Small MLD Query fixes and MLDv2 Query implementation #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like the short option, the long option of --sleep|-z should have a required argument of seconds to sleep. Signed-off-by: Linus Lüssing <[email protected]>
The default MLD querier interval according to RFC2710 and RFC3810 is 125 seconds, not 120. Signed-off-by: Linus Lüssing <[email protected]>
Next to the already implemented MLDv1 Queries (RFC2710) this now implements MLDv2 Queries (RFC3810). And uses MLDv2 Queries by default, unless specified otherwise with the new --mld-version|-V option. The MLDv2 QQIC is calculated internally from the --sleep option (which defaults to 125). Other than that the MLDv2 Query S-Flag (--mld-sflag|-M) and QRV (--mld-qrv|-R) values can be configured. MLDv2 Query messages for "Multicast Address and Source Specific Queries" are not yet implemented and still to do. Therefore the "Number of Sources" field is not configurable yet either. Signed-off-by: Linus Lüssing <[email protected]>
|
What I guess might look a bit more complicated in this PR is the encoding of the Querier's Query Interval Code (QQIC). Ideally I would have liked to find a one-liner to calculate the inverse of the "QQI = (mant | 0x10) << (exp + 3)" specified in RFC3810. I looked at the PIM6SD code (https://github.com/troglobit/pim6sd/blob/master/src/mld6v2.c#L396), however found that a bit complicated, so I tried to find a "simpler" version here. If anyone finds an even simpler way, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two small fixes to mldq6. One fixes the usage of "--sleep ". The other adjusts and fixes the default query interval.
The third patch adds support for MLDv2 Queries. And sets MLDv2 as the default. (It seems that in the IETF PIM working group there are efforts to deprecate IGMPv2/MLDv1, so defaulting to the newer MLDv2 makes more sense to me.)