Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm sportradar id from rankings #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

rm sportradar id from rankings #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: ffsimulator
Title: Simulate Fantasy Football Seasons
Version: 1.2.3.01
Version: 1.2.3.02
Authors@R:
person(given = "Tan",
family = "Ho",
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Update available fantasypros rankings to include 2022
- Require ggplot2 3.4.0 for plotting features
- Draws from a slightly broader sample of players for season outcomes
- Fix weekly sims - fantasypros no longer returns sportradar ids (fixes #71)


---
Expand Down
6 changes: 3 additions & 3 deletions R/2_rankings.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ ffs_latest_rankings <- function(type = c("draft","week")) {
"bye",
"ecr",
"sd",
"sportradar_id" = "sportsdata_id",
# "sportradar_id" = "sportsdata_id",
"scrape_date")]

names(fp_cleaned)[2] <- "fantasypros_id"
names(fp_cleaned)[4] <- "team"
names(fp_cleaned)[8] <- "sportradar_id"
# names(fp_cleaned)[8] <- "sportradar_id"

if(all(is.na(fp_cleaned$bye))) fp_cleaned$bye <- 0

Expand All @@ -56,7 +56,7 @@ ffs_latest_rankings <- function(type = c("draft","week")) {
"team",
"ecr",
"sd",
"sportradar_id",
#"sportradar_id",
"scrape_date")]
names(fp_cleaned)[1] <- "player"

Expand Down
Loading