fix: gateway explorer links #251
Conversation
Thought to clarify that this change hides the link when the |
There was a problem hiding this comment.
As a point of policy, I'm also hesitant to merge changes that remove functionality with the current master of fedimint. I think when we want to target future changes, the game plan should be to maintain backwards compatibility (i.e. default to the mainnet link when !network) but priming the app to be ready for an incoming change when the API updates to get the new response type makes the most sense.
If you've got the time to make it backwards compatible, it'd be good to get into the habit of doing that. Otherwise we could just wait for the fedimint PR to land, there's no value in getting this into a 0.1.x release unless a gateway release is also ported with this network property, which I suspect won't happen.
| @@ -69,7 +69,7 @@ | |||
| "sort": "Sort" | |||
| }, | |||
| "info-card": { | |||
| "amboss_node_link_text": "View on amboss.space", | |||
| "open-node-in-explorer": "Open in explorer", | |||
There was a problem hiding this comment.
Not important, but we could change this to View on {{origin}} and update the t calls to include the origin of the link they pulled together. Not really worth holding up the PR, but ideally we avoid deviating from design wherever possible.
There was a problem hiding this comment.
Interpolation with origin results in this madness "View on https://mempool.space". Went with View on {{host}}
Updated the change to make it backward compatible in UI as a start |
When gateway is deployed on mainnet and testnet, gateway address and node links should point to valid mempool.space links.
On signet, we assume gateway is deployed on mutinynet.com where we point both links. When gateway is on regtest, or the network is not yet known, we don't show "view in explorer" links
Changes in gateway UI take effect after fedimint/fedimint#3455 which introduces
networkfield to gateway info. To validate these changes before the upstream changes modify thenetworkprop inFederationCardand observe how the links are affected. Valid network values are"main" | "test" | "signet" | "regtest"closes #242