Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Support feature-server image builds entirely from source #5153

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions .github/fork_workflows/fork_pr_integration_tests_aws.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,18 +51,11 @@ jobs:
aws-region: us-west-2
- name: Use AWS CLI
run: aws sts get-caller-identity
- name: Install uv
run: |
curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Get uv cache dir
id: uv-cache
run: |
echo "::set-output name=dir::$(uv cache dir)"
- name: uv cache
uses: actions/cache@v4
- name: Install the latest version of uv and set the python version
uses: astral-sh/setup-uv@v5
with:
path: ${{ steps.uv-cache.outputs.dir }}
key: ${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-uv-${{ hashFiles(format('**/py{0}-ci-requirements.txt', env.PYTHON)) }}
enable-cache: true
python-version: ${{ matrix.python-version }}
- name: Install apache-arrow on ubuntu
if: matrix.os == 'ubuntu-latest'
run: |
Expand All @@ -81,7 +74,9 @@ jobs:
- name: Test python
if: ${{ always() }} # this will guarantee that step won't be canceled and resources won't leak
run: |
pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "aws and not Snowflake and not BigQuery and not minio_registry"
pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "File and not Snowflake and not BigQuery and not minio_registry"
pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "dynamo and not Snowflake and not BigQuery and not minio_registry"
pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "Redshift and not Snowflake and not BigQuery and not minio_registry"
uv run --active pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "aws and not Snowflake and not BigQuery and not minio_registry"
uv run --active pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "File and not Snowflake and not BigQuery and not minio_registry"
uv run --active pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "dynamo and not Snowflake and not BigQuery and not minio_registry"
uv run --active pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "Redshift and not Snowflake and not BigQuery and not minio_registry"
- name: Minimize uv cache
run: uv cache prune --ci
21 changes: 8 additions & 13 deletions .github/fork_workflows/fork_pr_integration_tests_gcp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,18 +53,11 @@ jobs:
project_id: ${{ secrets.GCP_PROJECT_ID }}
- name: Use gcloud CLI
run: gcloud info
- name: Install uv
run: |
curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Get uv cache dir
id: uv-cache
run: |
echo "::set-output name=dir::$(uv cache dir)"
- name: uv cache
uses: actions/cache@v4
- name: Install the latest version of uv and set the python version
uses: astral-sh/setup-uv@v5
with:
path: ${{ steps.uv-cache.outputs.dir }}
key: ${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-uv-${{ hashFiles(format('**/py{0}-ci-requirements.txt', env.PYTHON)) }}
enable-cache: true
python-version: ${{ matrix.python-version }}
- name: Install apache-arrow on ubuntu
if: matrix.os == 'ubuntu-latest'
run: |
Expand All @@ -84,5 +77,7 @@ jobs:
if: ${{ always() }} # this will guarantee that step won't be canceled and resources won't leak
# Run only BigQuery and File tests without dynamo and redshift tests.
run: |
pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "BigQuery and not dynamo and not Redshift and not Snowflake and not minio_registry"
pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "File and not dynamo and not Redshift and not Snowflake and not minio_registry"
uv run --active pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "BigQuery and not dynamo and not Redshift and not Snowflake and not minio_registry"
uv run --active pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "File and not dynamo and not Redshift and not Snowflake and not minio_registry"
- name: Minimize uv cache
run: uv cache prune --ci
21 changes: 8 additions & 13 deletions .github/fork_workflows/fork_pr_integration_tests_snowflake.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,11 @@ jobs:
uses: actions/setup-go@v2
with:
go-version: 1.18.0
- name: Install uv
run: |
curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Get uv cache dir
id: uv-cache
run: |
echo "::set-output name=dir::$(uv cache dir)"
- name: uv cache
uses: actions/cache@v4
- name: Install the latest version of uv and set the python version
uses: astral-sh/setup-uv@v5
with:
path: ${{ steps.uv-cache.outputs.dir }}
key: ${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-uv-${{ hashFiles(format('**/py{0}-ci-requirements.txt', env.PYTHON)) }}
enable-cache: true
python-version: ${{ matrix.python-version }}
- name: Install apache-arrow on ubuntu
if: matrix.os == 'ubuntu-latest'
run: |
Expand All @@ -80,5 +73,7 @@ jobs:
SNOWFLAKE_CI_WAREHOUSE: ${{ secrets.SNOWFLAKE_CI_WAREHOUSE }}
# Run only Snowflake BigQuery and File tests without dynamo and redshift tests.
run: |
pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "Snowflake and not dynamo and not Redshift and not Bigquery and not gcp and not minio_registry"
pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "File and not dynamo and not Redshift and not Bigquery and not gcp and not minio_registry"
uv run --active pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "Snowflake and not dynamo and not Redshift and not Bigquery and not gcp and not minio_registry"
uv run --active pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "File and not dynamo and not Redshift and not Bigquery and not gcp and not minio_registry"
- name: Minimize uv cache
run: uv cache prune --ci
20 changes: 7 additions & 13 deletions .github/workflows/java_master_only.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,19 +118,11 @@ jobs:
with:
python-version: 3.11
architecture: x64
- name: Install uv
run: |
curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Get uv cache dir
id: uv-cache
run: |
echo "::set-output name=dir::$(uv cache dir)"
- name: uv cache
uses: actions/cache@v4
- name: Install the latest version of uv and set the python version
uses: astral-sh/setup-uv@v5
with:
path: ${{ steps.uv-cache.outputs.dir }}
key: ${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-uv-${{ hashFiles(format('**/py{0}-ci-requirements.txt', env.PYTHON)) }}

enable-cache: true
python-version: ${{ matrix.python-version }}
- name: Install Python dependencies
run: make install-python-dependencies-ci
- uses: actions/cache@v4
Expand Down Expand Up @@ -158,4 +150,6 @@ jobs:
- name: Use AWS CLI
run: aws sts get-caller-identity
- name: Run integration tests
run: make test-java-integration
run: uv run --active make test-java-integration
- name: Minimize uv cache
run: uv cache prune --ci
21 changes: 8 additions & 13 deletions .github/workflows/java_pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -167,26 +167,21 @@ jobs:
with:
python-version: 3.11
architecture: x64
- name: Install uv
run: |
curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Get uv cache dir
id: uv-cache
run: |
echo "::set-output name=dir::$(uv cache dir)"
- name: uv cache
uses: actions/cache@v4
with:
path: ${{ steps.uv-cache.outputs.dir }}
key: ${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-uv-${{ hashFiles(format('**/py{0}-ci-requirements.txt', env.PYTHON)) }}
- name: Install the latest version of uv and set the python version
uses: astral-sh/setup-uv@v5
with:
enable-cache: true
python-version: 3.11
- name: Install dependencies
run: make install-python-dependencies-ci
- name: Run integration tests
run: make test-java-integration
run: uv run --active make test-java-integration
- name: Save report
uses: actions/upload-artifact@v4
if: failure()
with:
name: it-report
path: spark/ingestion/target/test-reports/TestSuite.txt
retention-days: 5
- name: Minimize uv cache
run: uv cache prune --ci
11 changes: 8 additions & 3 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,15 @@ jobs:
with:
python-version: "3.11"
architecture: x64
- name: Install uv
run: curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Install the latest version of uv and set the python version
uses: astral-sh/setup-uv@v5
with:
enable-cache: true
python-version: 3.11
- name: Install dependencies
run: |
make install-python-dependencies-ci
- name: Lint python
run: make lint-python
run: uv run --active make lint-python
- name: Minimize uv cache
run: uv cache prune --ci
18 changes: 7 additions & 11 deletions .github/workflows/master_only.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,11 @@ jobs:
aws-region: us-west-2
- name: Use AWS CLI
run: aws sts get-caller-identity
- name: Install uv
run: curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Get uv cache dir
id: uv-cache
run: |
echo "::set-output name=dir::$(uv cache dir)"
- name: uv cache
uses: actions/cache@v4
- name: Install the latest version of uv and set the python version
uses: astral-sh/setup-uv@v5
with:
path: ${{ steps.uv-cache.outputs.dir }}
key: ${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-uv-${{ hashFiles(format('**/py{0}-ci-requirements.txt', env.PYTHON)) }}
enable-cache: true
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: make install-python-dependencies-ci
- name: Setup Redis Cluster
Expand All @@ -85,9 +79,11 @@ jobs:
SNOWFLAKE_CI_PASSWORD: ${{ secrets.SNOWFLAKE_CI_PASSWORD }}
SNOWFLAKE_CI_ROLE: ${{ secrets.SNOWFLAKE_CI_ROLE }}
SNOWFLAKE_CI_WAREHOUSE: ${{ secrets.SNOWFLAKE_CI_WAREHOUSE }}
run: pytest --verbose --color=yes sdk/python/tests --integration --benchmark --benchmark-autosave --benchmark-save-data --durations=5
run: uv run --active pytest --verbose --color=yes sdk/python/tests --integration --benchmark --benchmark-autosave --benchmark-save-data --durations=5
- name: Upload Benchmark Artifact to S3
run: aws s3 cp --recursive .benchmarks s3://feast-ci-pytest-benchmark
- name: Minimize uv cache
run: uv cache prune --ci

build-all-docker-images:
if: github.repository == 'feast-dev/feast'
Expand Down
18 changes: 7 additions & 11 deletions .github/workflows/nightly-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,17 +117,11 @@ jobs:
aws-region: us-west-2
- name: Use AWS CLI
run: aws sts get-caller-identity
- name: Install uv
run: curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Get uv cache dir
id: uv-cache
run: |
echo "::set-output name=dir::$(uv cache dir)"
- name: uv cache
uses: actions/cache@v4
- name: Install the latest version of uv and set the python version
uses: astral-sh/setup-uv@v5
with:
path: ${{ steps.uv-cache.outputs.dir }}
key: ${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-uv-${{ hashFiles(format('**/py{0}-ci-requirements.txt', env.PYTHON)) }}
enable-cache: true
python-version: ${{ matrix.python-version }}
- name: Install apache-arrow on ubuntu
if: matrix.os == 'ubuntu-latest'
run: |
Expand All @@ -154,4 +148,6 @@ jobs:
SNOWFLAKE_CI_PASSWORD: ${{ secrets.SNOWFLAKE_CI_PASSWORD }}
SNOWFLAKE_CI_ROLE: ${{ secrets.SNOWFLAKE_CI_ROLE }}
SNOWFLAKE_CI_WAREHOUSE: ${{ secrets.SNOWFLAKE_CI_WAREHOUSE }}
run: make test-python-integration
run: uv run --active make test-python-integration
- name: Minimize uv cache
run: uv cache prune --ci
47 changes: 47 additions & 0 deletions .github/workflows/pr_image_build_from_source.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: pr-image-build-from-source

on:
push:
branches:
- main
#pull_request:
# types:
# - opened
# - synchronize
# - labeled
# paths-ignore:
# - 'community/**'
# - 'docs/**'
# - 'examples/**'

jobs:
image-build-from-source:
if:
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
github.event.pull_request.base.repo.full_name == 'feast-dev/feast'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up QEMU
uses: docker/setup-qemu-action@v3
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
with:
install: true
- name: Build grpc builder image from source
uses: docker/build-push-action@v6
with:
context: sdk/python/feast/infra/feature_servers/multicloud
file: sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.builder.grpc
load: true
tags: grpc-builder:latest
- name: Build arrow builder image from source
uses: docker/build-push-action@v6
with:
context: sdk/python/feast/infra/feature_servers/multicloud
file: sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.builder.arrow
load: true
tags: feast-sdist-builder:latest
- name: Run cachi2-based feast release image build from source
run: source ./infra/scripts/cachi2.sh
18 changes: 7 additions & 11 deletions .github/workflows/pr_integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,17 +78,11 @@ jobs:
aws-region: us-west-2
- name: Use AWS CLI
run: aws sts get-caller-identity
- name: Install uv
run: curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Get uv cache dir
id: uv-cache
run: |
echo "::set-output name=dir::$(uv cache dir)"
- name: uv cache
uses: actions/cache@v4
- name: Install the latest version of uv and set the python version
uses: astral-sh/setup-uv@v5
with:
path: ${{ steps.uv-cache.outputs.dir }}
key: ${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-uv-${{ hashFiles(format('**/py{0}-ci-requirements.txt', env.PYTHON)) }}
enable-cache: true
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: make install-python-dependencies-ci
- name: Setup Redis Cluster
Expand All @@ -104,4 +98,6 @@ jobs:
SNOWFLAKE_CI_PASSWORD: ${{ secrets.SNOWFLAKE_CI_PASSWORD }}
SNOWFLAKE_CI_ROLE: ${{ secrets.SNOWFLAKE_CI_ROLE }}
SNOWFLAKE_CI_WAREHOUSE: ${{ secrets.SNOWFLAKE_CI_WAREHOUSE }}
run: make test-python-integration
run: uv run --active make test-python-integration
- name: Minimize uv cache
run: uv cache prune --ci
18 changes: 7 additions & 11 deletions .github/workflows/pr_local_integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,25 +40,21 @@ jobs:
with:
python-version: ${{ matrix.python-version }}
architecture: x64
- name: Install uv
run: curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Get uv cache dir
id: uv-cache
run: |
echo "dir=$(uv cache dir)" >> $GITHUB_OUTPUT
- name: uv cache
uses: actions/cache@v4
- name: Install the latest version of uv and set the python version
uses: astral-sh/setup-uv@v5
with:
path: ${{ steps.uv-cache.outputs.dir }}
key: ${{ runner.os }}-${{ matrix.python-version }}-uv-${{ hashFiles(format('**/py{0}-ci-requirements.txt', matrix.python-version)) }}
enable-cache: true
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: make install-python-dependencies-ci
- name: Test local integration tests
if: ${{ always() }} # this will guarantee that step won't be canceled and resources won't leak
run: make test-python-integration-local
run: uv run --active make test-python-integration-local
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: 1.22.9
- name: Operator Data Source types test
run: make -C infra/feast-operator test-datasources
- name: Minimize uv cache
run: uv cache prune --ci
18 changes: 7 additions & 11 deletions .github/workflows/pr_remote_rbac_integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,15 @@ jobs:
with:
python-version: ${{ matrix.python-version }}
architecture: x64
- name: Install uv
run: curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Get uv cache dir
id: uv-cache
run: |
echo "dir=$(uv cache dir)" >> $GITHUB_OUTPUT
- name: uv cache
uses: actions/cache@v4
- name: Install the latest version of uv and set the python version
uses: astral-sh/setup-uv@v5
with:
path: ${{ steps.uv-cache.outputs.dir }}
key: ${{ runner.os }}-${{ matrix.python-version }}-uv-${{ hashFiles(format('**/py{0}-ci-requirements.txt', matrix.python-version)) }}
enable-cache: true
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: make install-python-dependencies-ci
- name: Test rbac and remote feature integration tests
if: ${{ always() }} # this will guarantee that step won't be canceled and resources won't leak
run: make test-python-integration-rbac-remote
run: uv run --active make test-python-integration-rbac-remote
- name: Minimize uv cache
run: uv cache prune --ci
Loading
Loading