Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and apply unified Formatting settings #17

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Rdeisenroth
Copy link
Collaborator

@Rdeisenroth Rdeisenroth commented Nov 8, 2022

Dieser PR bietet:

  • editorconfig
  • einheitliche Formatierungseinstellungen für LaTeX-Dokumente
  • Einheitliche Zeilenumbrüche (wandelt clrf in lf um)
  • End of File fixing (immer eine leere Zeile am Ende haben)
  • Pre-Commit-Hook für bequemes prüfen vorm Pushen (auch wenn latexindent aktuell recht lange braucht)
  • prüft diese Per CI bei Pull-Requests
  • verbessert die publish-action

Dabei musste ich jetzt einige Annahmen treffen weil das manchmal unterschiedlich war je nach Datei:

  • Ich hab jz mal angenommen du willst tab indentation, aber bei manchen LaTeX-Files hast du auch spaces genommen
  • Ich hab für jede Sprache die "konfliktfreiste" Config gewählt, an sich könnte bzw. sollte man aber auch für alle Sprachen Tabs/Spaces einheitlich festlegen

Falls du andere vorstellungen hast kann ich die Settings gerne auch noch anpassen^^

@Rdeisenroth Rdeisenroth force-pushed the feature/unified-formatting branch from e8fe9b4 to f2357b9 Compare May 31, 2023 09:55
@fdamken
Copy link
Owner

fdamken commented Nov 8, 2023

Can you maybe update this PR with the latest changes? Sorry that this took so long, I forgot about it.

@Rdeisenroth Rdeisenroth marked this pull request as draft August 20, 2024 20:06
@Rdeisenroth
Copy link
Collaborator Author

Alright, i finally got around to finishing this PR. I also updated the build script to use latexmk and the algotex-image, thus eliminating the copyright issue of having the tuda-logo.pdf stored in the repo. One thing we could further optimize is to either use the cache action or preferably build a docker image with the necessairy dependencies already installed published in ghcr. This could speed up compile times to about 50 seconds per pdf.

Side note: Maybe you should configure your repo not to automatically run github actions from PRs

@Rdeisenroth
Copy link
Collaborator Author

Ok i have no idea why the pipeline fails. Locally with act it works

@Rdeisenroth
Copy link
Collaborator Author

this has to somehow have cached an old config... Otherwise i see no way why it fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants