Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test by updating console output fixture #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andyw8
Copy link

@andyw8 andyw8 commented Apr 3, 2025

  • Add an entry to CHANGELOG.md that links to this PR under the "main (unreleased)" heading. (not done since this only affects the tests)

Description:

When checking out the repo and testing locally I was seeing a failure. It was due to a newer simplecov-console (v0.9.3) having an additional dependency.

@andyw8
Copy link
Author

andyw8 commented Apr 3, 2025

The Codecov issue mentioned in #28 may still exist though.

@andyw8
Copy link
Author

andyw8 commented Apr 4, 2025

Hmm, still failing I see. Let me investigate some more.

@andyw8 andyw8 force-pushed the andyw8/update-test-fixture branch from ae344e8 to ce41041 Compare April 4, 2025 02:18
@andyw8
Copy link
Author

andyw8 commented Apr 4, 2025

Ok it's passing for 3.0 at least now.

What do you think about the approach of committing Gemfile.lock, but having a rm Gemfile.lock step in CI before running Bundler? That means contributors can have the stability of passing tests when running locally, but CI will still be testing against the latest releases of any dependencies.

@andyw8
Copy link
Author

andyw8 commented Apr 4, 2025

🤔 Actually, shouldn't the report be listing gems for the test/dummy app rather than those for rails_stats itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant