Update README.md #261
Open
Update README.md #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Van den Broeck <[email protected]>
mcollina
reviewed
Jul 23, 2024
| @@ -84,6 +84,8 @@ A session store. Needs the following methods: | |||
|
|
|||
| Compatible to stores from [express-session](https://github.com/expressjs/session). | |||
|
|
|||
| Using an async store which connects to external services requires you to add the `trustProxy` setting to your fastify instance if you want to use secure cookies over https. | |||
There was a problem hiding this comment.
Suggested change
| Using an async store which connects to external services requires you to add the `trustProxy` setting to your fastify instance if you want to use secure cookies over https. | |
| If you are terminating HTTPs at | |
| the reverse proxy, you need to add the `trustProxy` setting to your fastify instance if you want to use secure cookies. |
I think this might be a better representation of the problem. I don't see how an async store could impact/change this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion on: #250
Documents the change that requires trustProxy on the fastify instance.