Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: preparation for fastify@5 #127

Merged
merged 4 commits into from
Mar 18, 2024
Merged

feat: preparation for fastify@5 #127

merged 4 commits into from
Mar 18, 2024

Conversation

synapse
Copy link
Contributor

@synapse synapse commented Mar 14, 2024

Ref: fastify/fastify#5116

Checklist

@Uzlopak Uzlopak changed the base branch from master to next March 14, 2024 14:25
gurgunday
gurgunday reviewed Mar 14, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
synapse and others added 3 commits March 14, 2024 16:13
@simoneb
Copy link

simoneb commented Mar 18, 2024

Is this good to merge?

@climba03003
Copy link
Member

Is this good to merge?

We need some clarification on the next step in Collaborator Discussion.
For now, we just hold the PR open and marked it as Ready for Release.

@climba03003 climba03003 changed the title Update for Fastify v5 Issue v5 release Mar 18, 2024
@climba03003 climba03003 changed the title Issue v5 release feat: preparation for fastify@5 Mar 18, 2024
@climba03003 climba03003 merged commit 834de3e into fastify:next Mar 18, 2024
14 checks passed
@simoneb
Copy link

simoneb commented Mar 18, 2024

I see you merged though

@climba03003
Copy link
Member

climba03003 commented Mar 18, 2024 •
edited
Loading

I double checked others repository and how it's done.
It generally merged the PR and create a new issue for release.
See #130

So, I merged it.

@simoneb
Copy link

simoneb commented Mar 18, 2024

Roger, makes sense

@synapse synapse mentioned this pull request Mar 22, 2024
Closed
jsumners pushed a commit that referenced this pull request Jul 17, 2024
@synapse @gurgunday @jsumners
feat: preparation for fastify@5 (#127)
dcae31b 
* update for v5

* Update .github/workflows/ci.yml

Co-authored-by: Gürgün Dayıoğlu <[email protected]>
Signed-off-by: Cristian Barlutiu <[email protected]>

* reverted Tap back to v16

* upgraded tap to 18

---------

Signed-off-by: Cristian Barlutiu <[email protected]>
Co-authored-by: Gürgün Dayıoğlu <[email protected]>
jsumners added a commit that referenced this pull request Jul 22, 2024
@jsumners @synapse @gurgunday
Merge next into master (#138)
a31fe18 
* feat: preparation for fastify@5 (#127)

* update for v5

* Update .github/workflows/ci.yml

Co-authored-by: Gürgün Dayıoğlu <[email protected]>
Signed-off-by: Cristian Barlutiu <[email protected]>

* reverted Tap back to v16

* upgraded tap to 18

---------

Signed-off-by: Cristian Barlutiu <[email protected]>
Co-authored-by: Gürgün Dayıoğlu <[email protected]>

* feat: preparation for fastify@5 (#127)

* update for v5

* Update .github/workflows/ci.yml

Co-authored-by: Gürgün Dayıoğlu <[email protected]>
Signed-off-by: Cristian Barlutiu <[email protected]>

* reverted Tap back to v16

* upgraded tap to 18

---------

Signed-off-by: Cristian Barlutiu <[email protected]>
Co-authored-by: Gürgün Dayıoğlu <[email protected]>

* update fastify deps

* update fastify deps

* update fastify deps

---------

Signed-off-by: Cristian Barlutiu <[email protected]>
Co-authored-by: Cristian Barlutiu <[email protected]>
Co-authored-by: Gürgün Dayıoğlu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb left review comments

@gurgunday gurgunday gurgunday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
v5 Work
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@synapse @simoneb @climba03003 @gurgunday