Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for typing_extensions.Doc (PEP 727)? #1111

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jeroendecroos
Copy link

I've added tests but not yet documentation. I can add that if this feature has a chance of acceptance.

I've opened a question for this feature here: #1110

Copy link

github-actions bot commented Jan 6, 2025

📝 Docs preview for commit 8c5430f at: https://77700f62.typertiangolo.pages.dev

Copy link

github-actions bot commented Jan 6, 2025

📝 Docs preview for commit b68c1e2 at: https://83732f8d.typertiangolo.pages.dev

@jeroendecroos
Copy link
Author

It seems that this feature would require python >= 3.8 due to the typing_extensions.Doc is only supported for >=4.8.0. Made some small changes to ignore that issue for now to get at least some CI testing to run.

I don't see yet any open issue to deprecate 3.7?

@svlandeg
Copy link
Member

svlandeg commented Jan 7, 2025

The PR and discussion for dropping support for Python 3.7 is here: #830

@svlandeg svlandeg marked this pull request as draft January 7, 2025 11:11
@svlandeg svlandeg changed the title ✨ Add support for typing_extensions.Doc (PEP 727)? ✨ Add support for typing_extensions.Doc (PEP 727)? Jan 7, 2025
@svlandeg svlandeg added the feature New feature, enhancement or request label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature, enhancement or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants