-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Update documentation to refer to list
instead of List
#1147
base: main
Are you sure you want to change the base?
Conversation
List
instead of list
List
instead of list
📝 Docs preview for commit 74008c6 at: https://55dfa7c7.sqlmodel.pages.dev Modified Pages |
List
instead of list
list
instead of List
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Yes - this is a good catch. The older Python 3.7 examples do use List
, but it makes sense to update the surrounding text to reflect the newest examples. In fact, I searched through the documentation and there's more cases like this, still referring to List
. I'll take this opportunity to update all of them.
📝 Docs preview for commit 7ba67fa at: https://471b13fc.sqlmodel.pages.dev Modified Pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be ready to merge! 🎉
All of the examples use lowercase
list
, but this text referrers toList
(which is imported from Typing).I suspect it's supposed to be lowercase.