feat: Store sending attachment in temporary file storage #1921
+89
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krille-chan
force-pushed
the
krille/store-sending-attachment-in-file-storage
branch
3 times, most recently
from
e979031
to
f89f01d
Compare
krille-chan
force-pushed
the
krille/store-sending-attachment-in-file-storage
branch
from
f89f01d
to
be2fc89
Compare
This could make retrying to send files more easy as the file is stored in the file storage. This just replaces the current approach to store the file in the memory instead so they are gone on the next session. For this we need a deleteFile() method for the database.
krille-chan
force-pushed
the
krille/store-sending-attachment-in-file-storage
branch
from
be2fc89
to
8f6deb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could make retrying to send
files more easy as the file is
stored in the file storage.