Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove IntWrapper #1964

Closed
wants to merge 1 commit into from

Conversation

jeffdaily
Copy link
Contributor

I could not access https://github.com/NVlabs/cub/issues/172 to understand whether IntWrapper was still necessary but the comment is from 5 years ago and causes problems for the ROCm build.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 26, 2025
@facebook-github-bot
Copy link
Contributor

@bottler has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jeffdaily
Copy link
Contributor Author

@bottler thank you for importing. The CI is failing due to undefined symbol. I don't know how this is related to the PR change.

from pytorch3d import _C
ImportError: /home/runner/.conda/envs/env/conda-bld/pytorch3d_1743032983446/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.12/site-packages/pytorch3d/_C.cpython-312-x86_64-linux-gnu.so: undefined symbol: _ZN3c105ErrorC2ENS_14SourceLocationESs

which is

c10::Error::Error(c10::SourceLocation, std::basic_string<char, std::char_traits<char>, std::allocator<char> >)

@bottler
Copy link
Contributor

bottler commented Mar 27, 2025

That's not the fault of this PR. CI is failing like that on main and currently fails on the previous commit, although it didn't originally fail when that commit landed. So something external has changed which breaks the github action.

I can see meta's internal CI is fine with this PR.

@jeffdaily
Copy link
Contributor Author

Does that mean we can merge this PR even though other CI failures exist?

@facebook-github-bot
Copy link
Contributor

@bottler merged this pull request in 0a59450.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants