Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply import merging for fbcode/mobile-vision/d2go (1 of 4) #214

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Apr 18, 2022

  1. apply import merging for fbcode/mobile-vision/d2go (1 of 4)

    Summary:
    Applies new import merging and sorting from µsort v1.0.
    
    When merging imports, µsort will make a best-effort to move associated
    comments to match merged elements, but there are known limitations due to
    the diynamic nature of Python and developer tooling. These changes should
    not produce any dangerous runtime changes, but may require touch-ups to
    satisfy linters and other tooling.
    
    Note that µsort uses case-insensitive, lexicographical sorting, which
    results in a different ordering compared to isort. This provides a more
    consistent sorting order, matching the case-insensitive order used when
    sorting import statements by module name, and ensures that "frog", "FROG",
    and "Frog" always sort next to each other.
    
    For details on µsort's sorting and merging semantics, see the user guide:
    https://usort.readthedocs.io/en/stable/guide.html#sorting
    
    Reviewed By: jreese
    
    Differential Revision: D35559658
    
    fbshipit-source-id: af9d17051a3db9a8ec4b7497d623e2e5f1762129
    lisroach authored and facebook-github-bot committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    86e9fb5 View commit details
    Browse the repository at this point in the history